CDRIVER-5901 support auto encryption in unified tests #2004
+1,694
−917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
reviewed
May 5, 2025
Co-authored-by: Kevin Albertson <[email protected]>
kevinAlbs
reviewed
May 9, 2025
src/libmongoc/tests/json/client_side_encryption/unified/fle2v2-BypassQueryAnalysis.json
Outdated
Show resolved
Hide resolved
kevinAlbs
approved these changes
May 19, 2025
eramongodb
requested changes
May 19, 2025
src/libmongoc/tests/json/client_side_encryption/unified/maxWireVersion.json
Show resolved
Hide resolved
src/libmongoc/tests/unified/runner.c
Outdated
| @@ -953,6 +963,51 @@ test_setup_initial_data (test_t *test, bson_error_t *error) | |||
| memset (error, 0, sizeof (bson_error_t)); | |||
| } | |||
|
|
|||
| // Also drop `enxcol_.<coll>.esc` and `enxcol_.<coll>.ecoc` in case the collection will be used for QE. | |||
There was a problem hiding this comment.
Are these series of blocks implementing this part of the CSFLE spec?
- Drop the collection with name
encryptedFields["escCollection"]. IfencryptedFields["escCollection"]is not set, use the collection nameenxcol_.<collectionName>.esc.- Drop the collection with name
encryptedFields["ecocCollection"]. IfencryptedFields["ecocCollection"]is not set, use the collection nameenxcol_.<collectionName>.ecoc.- Drop the collection
collectionName.
If so, recommend adding a link/reference to this spec (+ is this missing handling of "escCollection"/"ecocCollection"?). If not, recommend elaborating what is meant by "in case the collection will be used for QE" (that is, what is motivating these drop commands?).
There was a problem hiding this comment.
No, this implements part of the initialData spec. Added a comment. The ability to change the encryption metadata collection names was removed so it's omitted here and the default names are hardcoded.
Co-authored-by: Ezra Chung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Evergreen: https://spruce.mongodb.com/version/6827b7ca805919000708843e